Adjust virtual keyboard size base on input method candidates.

chrome/browser/resources/keyboard/ime.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview An input method UI implementation
  */
 
 /**
  * Const variables
@@ skipping 105 matching lines @@
       that.appendChild(candidate);
       candidate.onclick = function() {
         that.candidateClicked(index);
       };
     }
     for (var i = 0; i < IME_MAX_CANDIDATES; i++) {
       createCandidateButton(i);
     }
 
     this.appendChild(this.pageDown_);
+    this.update();
   },
 
   /**
+   * Returns true if Ime Ui is visible.
+   * @return {boolean}
+   */
+  get visible() {
+    return this.style.display != 'none';
+  },
+
+  /**
    * Sets the input cursor location.
    * @param {number} x The x of the input cursor coordinates.
    * @param {number} y The y of the input cursor coordinates.
    * @param {number} w The width of the input cursor.
    * @param {number} h The height of the input cursor.
    * @return {void}
    */
   setCursorLocation: function(x, y, w, h) {
     // Currently we do nothing.
   },
@@ skipping 25 matching lines @@
     } else {
       for (var i = 0; i < this.candidates_.length; i++) {
         this.candidates_[i].text = '';
       }
     }
     this.table_ = table;
     this.update();
   },
 
   update : function() {
-    // TODO(penghuang) Add API for show and hide ImeUI.
-    // Currently, ImeUi is always visible.
-    if (true || (this.table_ && this.table_.visible) || this.auxiliary_.text_) {
-      this.style.display = 'block';
-    } else {
-      this.style.display = 'none';
+    var should_visible =

[bryeung, 2011/06/03 19:14:52]

maybe just visible or visible_now?

[Peng, 2011/06/03 22:22:10]

Done.

+      (this.table_ && this.table_.visible) || this.auxiliary_.text_;
+
+    if (should_visible == this.visible) {
+      return;
     }
 
+    if (should_visible) {
+      chrome.experimental.input.setKeyboardHeight(300 + IME_HEIGHT);
+      this.style.display = 'inline-block';
+    }
+    else {

[bryeung, 2011/06/03 19:14:52]

nit: move to line above

[Peng, 2011/06/03 22:22:10]

Done.

+      this.style.display = 'none';
+      chrome.experimental.input.setKeyboardHeight(300);
+    }
     // TODO(penghuang) Adjust the width of all items in ImeUi to fill the width
     // of keyboard.
   },
 
   /**
    * Candidate is clicked.
    * @param {number} index The index of the candidate.
    * @return {void}
    */
   candidateClicked: function(index) {
@@ skipping 64 matching lines @@
 
 /**
  * Updates Ime Ui. It should be called when window is resized.
  * @return {void}
  */
 function updateIme() {
   if (imeui) {
     imeui.update();
   }
 }