WebGraphicsContext3DCommandBufferImpl cleanup, Canvas2D thottling fix, GpuScheduler fix.

gpu/command_buffer/service/mocks.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/threading/thread.h"
 #include "gpu/command_buffer/service/mocks.h"
 
 namespace gpu {
 
 AsyncAPIMock::AsyncAPIMock() {
   testing::DefaultValue<error::Error>::Set(
       error::kNoError);
 }
 
 AsyncAPIMock::~AsyncAPIMock() {}
 
 void AsyncAPIMock::SetToken(unsigned int command,
                             unsigned int arg_count,
                             const void* _args) {
   DCHECK(engine_);
   DCHECK_EQ(1u, command);
   DCHECK_EQ(1u, arg_count);
   const cmd::SetToken* args =
       static_cast<const cmd::SetToken*>(_args);
   engine_->set_token(args->token);
 }
 
+SpecializedAsyncAPIMock::SpecializedAsyncAPIMock() {}

[apatrick_chromium, 2011/06/03 18:58:52]

The name does not describe what the specialized mock does. How about
SlowAsyncAPIMock or something?

[jbates, 2011/06/03 21:27:32]

Done. But not Slow, because it is still a generic class used for all tests. It's
just that it has specialized the DoCommand method for specific command behavior.

+
+SpecializedAsyncAPIMock::~SpecializedAsyncAPIMock() {}
+
+error::Error SpecializedAsyncAPIMock::DoCommand(unsigned int command,
+                                                unsigned int arg_count,
+                                                const void* cmd_data) {
+  if (command == kTestPauseCommand) {
+    // 3 ms sleep, to surpass the 2ms cutoff in GpuScheduler
+    base::PlatformThread::Sleep(3);

[apatrick_chromium, 2011/06/03 18:58:52]

I fear this is going to make the test flaky if the timer precision is not
sufficient. How about a loop that calls base::TimeTicks::Now to verify that the
required amount of time has elapsed and sleep again if it has not.

[jbates, 2011/06/03 21:27:32]

Done.

+  }
+  return AsyncAPIMock::DoCommand(command, arg_count, cmd_data);
+}
+
 namespace gles2 {
 
 MockShaderTranslator::MockShaderTranslator() {}
 
 MockShaderTranslator::~MockShaderTranslator() {}
 
 }  // namespace gles2
 }  // namespace gpu