Issue 7058022: Fixes crash with instant enabled. The crash would occur if you turned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7058022: Fixes crash with instant enabled. The crash would occur if you turned (Closed)

Created:
9 years, 6 months ago by sky

Modified:
9 years, 6 months ago

Reviewers:
Jay Civelli

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fixes crash with instant enabled. The crash would occur if you turned on preload and your default search provider doesn't support instant. BUG=84671 TEST=turn on instant, enable 'Preload Instant Search' in about:flags, change your default search provider to something other than GOogle, focus the omnibox and make sure you don't crash. R=jcivelli@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87660

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/instant/instant_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages