Issue 7058003: Take out pref watching from HostZoomMap, in preparation of removing Profile from it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7058003: Take out pref watching from HostZoomMap, in preparation of removing Profile from it. (Closed)

Created:
9 years, 7 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, Jói, A S Alam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Take out pref watching from HostZoomMap, in preparation of removing Profile from it. I've moved watching changes to the default zoom level to the Profile class. The other value being watched was for the per-hostname level, which is only needed if it's being synced. However this pref stopped being synced in r51849, so the removal is roughly a revert of 44056. BUG=76788 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86303

Patch Set 1 : '' #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -215 lines)			Patch
M	chrome/browser/prefs/browser_prefs.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/profiles/profile.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View	3 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/host_zoom_map.h	View	5 chunks	+2 lines, -16 lines	0 comments	Download
M	content/browser/host_zoom_map.cc	View	9 chunks	+8 lines, -76 lines	0 comments	Download
D	content/browser/host_zoom_map_unittest.cc	View	1 chunk	+0 lines, -120 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages