Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9575)

Unified Diff: chrome/browser/ui/views/browser_actions_container.h

Issue 7057058: Convert BrowserActionsContainer context menu from Menu2 to MenuItemView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implement reviewer recommendation. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/browser_actions_container.h
diff --git a/chrome/browser/ui/views/browser_actions_container.h b/chrome/browser/ui/views/browser_actions_container.h
index 07713d3309b4c579e55bad66cc4aa062cddd6bea..1d7e3cbedb06ce5ea924ae0f8769f22744ec2500 100644
--- a/chrome/browser/ui/views/browser_actions_container.h
+++ b/chrome/browser/ui/views/browser_actions_container.h
@@ -45,7 +45,7 @@ class SlideAnimation;
}
namespace views {
-class Menu2;
+class MenuItemView;
}
////////////////////////////////////////////////////////////////////////////////
@@ -130,9 +130,6 @@ class BrowserActionButton : public views::MenuButton,
// asynchronously.
ImageLoadingTracker tracker_;
- // Whether we are currently showing/just finished showing a context menu.
- bool showing_context_menu_;
-
// The default icon for our browser action. This might be non-empty if the
// browser action had a value for default_icon in the manifest.
SkBitmap default_icon_;
@@ -140,8 +137,8 @@ class BrowserActionButton : public views::MenuButton,
// The browser action shelf.
BrowserActionsContainer* panel_;
- scoped_refptr<ExtensionContextMenuModel> context_menu_contents_;
- scoped_ptr<views::Menu2> context_menu_menu_;
+ // The context menu. This member is non-NULL only when the menu is shown.
+ views::MenuItemView* context_menu_;
NotificationRegistrar registrar_;

Powered by Google App Engine
This is Rietveld 408576698