Escaping file names correctly. Also fixed a crush in chromeos debug build while saving a web page.

net/base/escape_unittest.cc

Index: net/base/escape_unittest.cc
diff --git a/net/base/escape_unittest.cc b/net/base/escape_unittest.cc
index 5211fdf4e48712b402e0eb8357c560ec4954f90c..24a6b571df0a26d96c241837b442815a84d81660 100644
--- a/net/base/escape_unittest.cc
+++ b/net/base/escape_unittest.cc
@@ -147,7 +147,7 @@ TEST(EscapeTest, EscapeUrlEncodedData) {
       "\x02\n\x1d !\"#$%&'()*+,-./0123456789:;"
       "<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ"
       "[\\]^_`abcdefghijklmnopqrstuvwxyz"
-      "{|}~\x7f\x80\xff"),
+      "{|}~\x7f\x80\xff", true),
     // Escaped
     "%02%0A%1D+!%22%23%24%25%26%27()*%2B,-./0123456789:%3B"
     "%3C%3D%3E%3F%40ABCDEFGHIJKLMNOPQRSTUVWXYZ"
@@ -155,6 +155,19 @@ TEST(EscapeTest, EscapeUrlEncodedData) {
     "%7B%7C%7D~%7F%80%FF");
 }
 
+TEST(EscapeTest, EscapeUrlEncodedDataSpace) {
+  ASSERT_EQ(

[Peter Kasting, 2011/06/07 18:08:43]

Nit: This indenting is bizarre.  Just do:

  ASSERT_EQ(EscapeUrlEncodedData("a b", true), "a+b");
  ASSERT_EQ(EscapeUrlEncodedData("a b", false), "a%20b");

[SeRya, 2011/06/08 12:24:28]

Done.

+    EscapeUrlEncodedData(
+      "a b", true),
+    // Escaped
+    "a+b");
+  ASSERT_EQ(
+    EscapeUrlEncodedData(
+      "a b", false),
+    // Escaped
+    "a%20b");
+}
+
 TEST(EscapeTest, UnescapeURLComponentASCII) {
   const UnescapeURLCaseASCII unescape_cases[] = {
     {"", UnescapeRule::NORMAL, ""},