Escaping file names correctly. Also fixed a crush in chromeos debug build while saving a web page.

net/base/escape.h

Index: net/base/escape.h
diff --git a/net/base/escape.h b/net/base/escape.h
index 65903296f5dc2148af2e174f56cc18e633a3d0ba..c0a17e7d52b6b4b99cd2fae557daaddad9e6a702 100644
--- a/net/base/escape.h
+++ b/net/base/escape.h
@@ -21,8 +21,10 @@ NET_API std::string EscapePath(const std::string& path);
 
 // Escape application/x-www-form-urlencoded content.  This includes:
 // non-printable, non-7bit, and (including space)  ?>=<;+'&%$#"![\]^`{|}
-// Space is escaped as + and other special characters as %XX (hex).
-NET_API std::string EscapeUrlEncodedData(const std::string& path);
+// Space is escaped as + (if use_plus is true) and other special characters
+// as %XX (hex).
+NET_API std::string EscapeUrlEncodedData(const std::string& path,
+                                         bool use_plus = true);

[ahendrickson, 2011/06/06 15:29:51]

Nit: The style guide does not allow default arguments in this case:

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Default_Arguments:

"we require all arguments to be explicitly specified, to force programmers to
consider the API and the values they are passing for each argument rather than
silently accepting defaults they may not be aware of"

[SeRya, 2011/06/07 12:16:04]

Done.

 
 // Escape all non-ASCII input.
 NET_API std::string EscapeNonASCII(const std::string& input);