Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: net/base/escape_unittest.cc

Issue 7057053: Escaping file names correctly. Also fixed a crush in chromeos debug build while saving a web page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed opening files with spaces in their names. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/escape_unittest.cc
diff --git a/net/base/escape_unittest.cc b/net/base/escape_unittest.cc
index 5211fdf4e48712b402e0eb8357c560ec4954f90c..cc5d26de5a44e11fd4a4b19687f53b26270dbab9 100644
--- a/net/base/escape_unittest.cc
+++ b/net/base/escape_unittest.cc
@@ -155,6 +155,19 @@ TEST(EscapeTest, EscapeUrlEncodedData) {
"%7B%7C%7D~%7F%80%FF");
}
+TEST(EscapeTest, EscapeUrlEncodedDataSpace) {
+ ASSERT_EQ(
+ EscapeUrlEncodedData(
+ "a b"),
+ // Escaped
+ "a+b");
+ ASSERT_EQ(
+ EscapeUrlEncodedData(
+ "a b", false),
+ // Escaped
+ "a%20b");
+}
+
TEST(EscapeTest, UnescapeURLComponentASCII) {
const UnescapeURLCaseASCII unescape_cases[] = {
{"", UnescapeRule::NORMAL, ""},
« chrome/browser/resources/file_manager/js/file_manager.js ('K') | « net/base/escape.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698