Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: chrome/browser/resources/print_preview.js

Issue 7057047: Print Preview: Preventing "Preview loading..." animation from rendering when not displayed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebasing Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/print_preview.html ('k') | chrome/browser/resources/print_preview_animations.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/print_preview.js
diff --git a/chrome/browser/resources/print_preview.js b/chrome/browser/resources/print_preview.js
index 9fa4e8bb40ea5c108a7b6cdce3b58121b2b53186..e0265ab1d0bf30f6f981c84b433e7c228288b2a5 100644
--- a/chrome/browser/resources/print_preview.js
+++ b/chrome/browser/resources/print_preview.js
@@ -47,7 +47,7 @@ function onLoad() {
$('printer-list').disabled = true;
$('print-button').disabled = true;
- $('dancing-dots').classList.remove('invisible');
+ showLoadingAnimation();
chrome.send('getDefaultPrinter');
}
@@ -343,7 +343,7 @@ function printFile() {
function requestPrintPreview() {
removeEventListeners();
printSettings.save();
- $('dancing-dots').classList.remove('invisible');
+ showLoadingAnimation();
chrome.send('getPreview', [getSettingsJSON()]);
}
@@ -442,7 +442,7 @@ function setColor(color) {
* should be displayed.
*/
function displayErrorMessage(errorMessage, showButton) {
- $('dancing-dots').classList.remove('invisible');
+ $('overlay-layer').classList.remove('invisible');
$('dancing-dots-text').classList.add('hidden');
$('error-text').innerHTML = errorMessage;
$('error-text').classList.remove('hidden');
@@ -474,7 +474,7 @@ function onPDFLoad() {
else
$('pdf-viewer').fitToHeight();
- $('dancing-dots').classList.add('invisible');
+ hideLoadingAnimation();
if (!previewModifiable)
fadeOutElement($('landscape-option'));
« no previous file with comments | « chrome/browser/resources/print_preview.html ('k') | chrome/browser/resources/print_preview_animations.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698