Print Preview: Preventing "Preview loading..." animation from rendering when not displayed.

chrome/browser/resources/print_preview.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var localStrings = new LocalStrings();
 
 // The total page count of the previewed document regardless of which pages the
 // user has selected.
 var totalPageCount = -1;
 
@@ skipping 29 matching lines @@
 
   if (!checkCompatiblePluginExists()) {
     displayErrorMessage(localStrings.getString('noPlugin'), false);
     $('mainview').parentElement.removeChild($('dummy-viewer'));
     return;
   }
   $('mainview').parentElement.removeChild($('dummy-viewer'));
 
   $('printer-list').disabled = true;
   $('print-button').disabled = true;
-  $('dancing-dots').classList.remove('invisible');
+  showLoadingAnimation();
   chrome.send('getDefaultPrinter');
 }
 
 /**
  * Adds event listeners to the settings controls.
  */
 function addEventListeners() {
   $('print-button').onclick = printFile;
 
   // Controls that require preview rendering.
@@ skipping 275 matching lines @@
   } else
     chrome.send('print', [getSettingsJSON()]);
 }
 
 /**
  * Asks the browser to generate a preview PDF based on current print settings.
  */
 function requestPrintPreview() {
   removeEventListeners();
   printSettings.save();
-  $('dancing-dots').classList.remove('invisible');
+  showLoadingAnimation();
   chrome.send('getPreview', [getSettingsJSON()]);
 }
 
 /**
  * Set the default printer. If there is one, generate a print preview.
  * @param {string} printer Name of the default printer. Empty if none.
  */
 function setDefaultPrinter(printer) {
   // Add a placeholder value so the printer list looks valid.
   addDestinationListOption('', '', true, true);
@@ skipping 78 matching lines @@
   pdfViewer.grayscale(!color);
 }
 
 /**
  * Display an error message in the center of the preview area.
  * @param {string} errorMessage The error message to be displayed.
  * @param {boolean} showButton Indivates whether the "Reopen the page" button
  * should be displayed.
  */
 function displayErrorMessage(errorMessage, showButton) {
-  $('dancing-dots').classList.remove('invisible');
+  $('overlay-layer').classList.remove('invisible');
   $('dancing-dots-text').classList.add('hidden');
   $('error-text').innerHTML = errorMessage;
   $('error-text').classList.remove('hidden');
   if (showButton)
     $('reopen-page').classList.remove('hidden');
   else
     $('reopen-page').classList.add('hidden');
 
   removeEventListeners();
   var pdfViewer = $('pdf-viewer');
@@ skipping 11 matching lines @@
 
 /**
  * Called when the PDF plugin loads its document.
  */
 function onPDFLoad() {
   if (isLandscape())
     $('pdf-viewer').fitToWidth();
   else
     $('pdf-viewer').fitToHeight();
 
-  $('dancing-dots').classList.add('invisible');
+  hideLoadingAnimation();
 
   if (!previewModifiable)
     fadeOutElement($('landscape-option'));
 
   updateCopiesButtonsState();
 }
 
 /**
  * Update the print preview when new preview data is available.
  * Create the PDF plugin as needed.
@@ skipping 476 matching lines @@
   this.isLandscape = '';
 }
 
 /**
  * Takes a snapshot of the print settings.
  */
 PrintSettings.prototype.save = function() {
   this.deviceName = getSelectedPrinterName();
   this.isLandscape = isLandscape();
 }