Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 7057041: Do all the font UMA work in PdfMetafileSkia::FinishDocument. (Closed)

Created:
9 years, 6 months ago by vandebo (ex-Chrome)
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Do all the font UMA work in PdfMetafileSkia::FinishDocument. BUG=80918 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87624

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -20 lines) Patch
M printing/pdf_metafile_skia.cc View 1 3 chunks +16 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vandebo (ex-Chrome)
9 years, 6 months ago (2011-05-30 21:56:39 UTC) #1
Chris Guillory
http://codereview.chromium.org/7057041/diff/1/printing/pdf_metafile_skia.cc File printing/pdf_metafile_skia.cc (right): http://codereview.chromium.org/7057041/diff/1/printing/pdf_metafile_skia.cc#newcode100 printing/pdf_metafile_skia.cc:100: SkFontID key = font_resources[font]->typeface()->uniqueID(); We can call UMA_HISTOGRAM_ENUMERATION here ...
9 years, 6 months ago (2011-05-31 18:15:45 UTC) #2
vandebo (ex-Chrome)
http://codereview.chromium.org/7057041/diff/1/printing/pdf_metafile_skia.cc File printing/pdf_metafile_skia.cc (right): http://codereview.chromium.org/7057041/diff/1/printing/pdf_metafile_skia.cc#newcode100 printing/pdf_metafile_skia.cc:100: SkFontID key = font_resources[font]->typeface()->uniqueID(); On 2011/05/31 18:15:45, Chris Guillory ...
9 years, 6 months ago (2011-05-31 18:55:11 UTC) #3
vandebo (ex-Chrome)
9 years, 6 months ago (2011-05-31 18:55:11 UTC) #4
Chris Guillory
LGTM
9 years, 6 months ago (2011-05-31 18:57:29 UTC) #5
commit-bot: I haz the power
9 years, 6 months ago (2011-06-02 17:29:07 UTC) #6
Change committed as 87624

Powered by Google App Engine
This is Rietveld 408576698