Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1943)

Unified Diff: chrome/browser/ui/webui/options/personal_options_handler.cc

Issue 7057038: dom-ui sync: Eliminate jank when customizing sync settings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: comment tweak Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/personal_options_handler.cc
===================================================================
--- chrome/browser/ui/webui/options/personal_options_handler.cc (revision 86339)
+++ chrome/browser/ui/webui/options/personal_options_handler.cc (working copy)
@@ -385,20 +385,20 @@
void PersonalOptionsHandler::ShowSyncActionDialog(const ListValue* args) {
ProfileSyncService* service = web_ui_->GetProfile()->GetProfileSyncService();
DCHECK(service);
- service->ShowErrorUI();
+ service->ShowErrorUI(web_ui_);
}
void PersonalOptionsHandler::ShowSyncLoginDialog(const ListValue* args) {
ProfileSyncService* service = web_ui_->GetProfile()->GetProfileSyncService();
DCHECK(service);
- service->ShowLoginDialog();
+ service->ShowLoginDialog(web_ui_);
ProfileSyncService::SyncEvent(ProfileSyncService::START_FROM_OPTIONS);
}
void PersonalOptionsHandler::ShowCustomizeSyncDialog(const ListValue* args) {
ProfileSyncService* service = web_ui_->GetProfile()->GetProfileSyncService();
DCHECK(service);
- service->ShowConfigure(false);
+ service->ShowConfigure(web_ui_, false);
}
void PersonalOptionsHandler::ThemesReset(const ListValue* args) {
@@ -431,5 +431,4 @@
image_url);
}
}
-
#endif
« no previous file with comments | « chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc ('k') | chrome/browser/ui/webui/options/sync_setup_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698