chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc - Issue 7057038: dom-ui sync: Eliminate jank when customizing sync settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc

Issue 7057038: dom-ui sync: Eliminate jank when customizing sync settings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: win/linux tweaks Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc

===================================================================

--- chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc (revision 84869)

+++ chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc (working copy)

@@ -1021,7 +1021,7 @@

GdkEventButton* event) {

if (sender == sync_error_button_) {

DCHECK(sync_service_ && !sync_service_->IsManaged());

- sync_service_->ShowErrorUI();

+ sync_service_->ShowErrorUI(NULL);

James Hawkins 2011/05/22 00:18:04 How does this work if the options page is already

csilv 2011/05/22 19:48:32 The behavior should be exactly the same as before.

}

return FALSE;