Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: chrome/browser/sync/sync_ui_util.cc

Issue 7057038: dom-ui sync: Eliminate jank when customizing sync settings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: win/linux tweaks Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/sync_ui_util.h" 5 #include "chrome/browser/sync/sync_ui_util.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/i18n/number_formatting.h" 8 #include "base/i18n/number_formatting.h"
9 #include "base/i18n/time_formatting.h" 9 #include "base/i18n/time_formatting.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 } 265 }
266 266
267 if (service->HasSyncSetupCompleted()) { 267 if (service->HasSyncSetupCompleted()) {
268 bool create_window = browser == NULL; 268 bool create_window = browser == NULL;
269 if (create_window) 269 if (create_window)
270 browser = Browser::Create(profile); 270 browser = Browser::Create(profile);
271 browser->ShowOptionsTab(chrome::kPersonalOptionsSubPage); 271 browser->ShowOptionsTab(chrome::kPersonalOptionsSubPage);
272 if (create_window) 272 if (create_window)
273 browser->window()->Show(); 273 browser->window()->Show();
274 } else { 274 } else {
275 service->ShowLoginDialog(); 275 service->ShowLoginDialog(NULL);
276 ProfileSyncService::SyncEvent(code); // UMA stats 276 ProfileSyncService::SyncEvent(code); // UMA stats
277 } 277 }
278 } 278 }
279 279
280 void AddBoolSyncDetail(ListValue* details, 280 void AddBoolSyncDetail(ListValue* details,
281 const std::string& stat_name, 281 const std::string& stat_name,
282 bool stat_value) { 282 bool stat_value) {
283 DictionaryValue* val = new DictionaryValue; 283 DictionaryValue* val = new DictionaryValue;
284 val->SetString("stat_name", stat_name); 284 val->SetString("stat_name", stat_name);
285 val->SetBoolean("stat_value", stat_value); 285 val->SetBoolean("stat_value", stat_value);
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 441
442 DictionaryValue* val = new DictionaryValue; 442 DictionaryValue* val = new DictionaryValue;
443 val->SetString("stat_name", "Autofill Migration Time"); 443 val->SetString("stat_name", "Autofill Migration Time");
444 val->SetString("stat_value", ConstructTime(info.autofill_migration_time)); 444 val->SetString("stat_value", ConstructTime(info.autofill_migration_time));
445 details->Append(val); 445 details->Append(val);
446 } 446 }
447 } 447 }
448 } 448 }
449 449
450 } // namespace sync_ui_util 450 } // namespace sync_ui_util
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698