Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1579)

Unified Diff: content/browser/tab_contents/tab_contents_observer.h

Issue 7057036: Add some missing information to TabContentsObserver docs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tab_contents/tab_contents_observer.h
===================================================================
--- content/browser/tab_contents/tab_contents_observer.h (revision 86172)
+++ content/browser/tab_contents/tab_contents_observer.h (working copy)
@@ -19,7 +19,9 @@
public IPC::Message::Sender {
public:
// Use this as a member variable in a class that uses the empty constructor
- // version of this interface.
+ // version of this interface. On destruction of TabContents being observed,
+ // the registrar must either be destroyed or explicitly set to observe
+ // another TabContents.
class Registrar {
public:
explicit Registrar(TabContentsObserver* observer);
@@ -124,6 +126,7 @@
protected:
friend class Registrar;
+ // Called from TabContents in response to having |this| added as an observer.
void SetTabContents(TabContents* tab_contents);
private:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698