Issue 7057030: Disable and turn off autofill for guest mode.

Issue 7057030: Disable and turn off autofill for guest mode. (Closed)

Created:
9 years, 7 months ago by xiyuan

Modified:
9 years, 7 months ago

Reviewers:
achuithb

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Disable and turn off autofill for guest mode. Also moved 'enable-screen-lock' disabling logic into chromeos specific area and add similar logic to disable 'change-picture-button' in guest mode. BUG=chromium-os:10020 TEST=Verify fix for chromium-os:10020 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86292

Patch Set 1 #

Total comments: 2

Patch Set 2 : address achuith's comments in set #1 #

Patch Set 3 : fix the missing semicolon. :p #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -5 lines)			Patch
	M	chrome/browser/resources/options/personal_options.html	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/resources/options/personal_options.js	View	1 2	3 chunks	+24 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

achuithb

LGTM http://codereview.chromium.org/7057030/diff/1/chrome/browser/resources/options/personal_options.js File chrome/browser/resources/options/personal_options.js (right): http://codereview.chromium.org/7057030/diff/1/chrome/browser/resources/options/personal_options.js#newcode99 chrome/browser/resources/options/personal_options.js:99: $('autofill-enabled').disabled = true; Curious - is it better ...

9 years, 7 months ago (2011-05-20 23:38:01 UTC) #2

xiyuan

http://codereview.chromium.org/7057030/diff/1/chrome/browser/resources/options/personal_options.js File chrome/browser/resources/options/personal_options.js (right): http://codereview.chromium.org/7057030/diff/1/chrome/browser/resources/options/personal_options.js#newcode99 chrome/browser/resources/options/personal_options.js:99: $('autofill-enabled').disabled = true; On 2011/05/20 23:38:01, achuith.bhandarkar wrote: > ...

9 years, 7 months ago (2011-05-20 23:52:39 UTC) #3

achuithb

9 years, 7 months ago (2011-05-21 20:30:36 UTC) #4

LGTM

On 2011/05/20 23:52:39, xiyuan wrote:
>
http://codereview.chromium.org/7057030/diff/1/chrome/browser/resources/option...
> File chrome/browser/resources/options/personal_options.js (right):
> 
>
http://codereview.chromium.org/7057030/diff/1/chrome/browser/resources/option...
> chrome/browser/resources/options/personal_options.js:99:
> $('autofill-enabled').disabled = true;
> On 2011/05/20 23:38:01, achuith.bhandarkar wrote:
> > Curious - is it better to cache the autofill-enabled dom element? Otherwise
> you
> > call getElementById which presumably searches the whole DOM tree, right?
We're
> > doing this everywhere so is it safe to assume getElementById is efficient?
> 
> I think you are right that use $() will incur a performance hit.
> 
> Not sure how big the improvement would be though so not changing it in all
> places.

Expand Messages | Collapse Messages