Issue 7057021: Fix a possible crash on windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7057021: Fix a possible crash on windows. (Closed)

Created:
9 years, 7 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
sehr (please use chromium), sehr, brettw

CC:
native-client-reviews_googlegroups.com

Base URL:
http://src.chromium.org/native_client/trunk/src/native_client/

Visibility:
Public.

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/shared/platform/win/time_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Nico

I don't have nacl write permissions I think, so if this LGTY, please land.

9 years, 7 months ago (2011-05-20 19:46:10 UTC) #1

brettw

LGTM, but I'm not sure I have write permissions either. David, can you land this?

9 years, 7 months ago (2011-05-21 20:28:47 UTC) #2

sehr (please use chromium)

LGTM, and I'll check it into NaCl for later pushing into Chrome.

9 years, 7 months ago (2011-05-22 04:42:46 UTC) #3

sehr (please use chromium)

9 years, 7 months ago (2011-05-24 17:45:03 UTC) #4

On 2011/05/22 04:42:46, sehr wrote:
> LGTM, and I'll check it into NaCl for later pushing into Chrome.

Fix committed to nacl as r5403.