Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: chrome/browser/ui/views/tabs/side_tab_strip.cc

Issue 7057014: Variety of tweaks to View API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/tabs/base_tab_strip.cc ('k') | chrome/browser/ui/views/tabs/tab.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/tabs/side_tab_strip.cc
===================================================================
--- chrome/browser/ui/views/tabs/side_tab_strip.cc (revision 86083)
+++ chrome/browser/ui/views/tabs/side_tab_strip.cc (working copy)
@@ -128,7 +128,7 @@
separator_(new views::View()),
first_tab_y_offset_(0),
ideal_height_(0) {
- SetID(VIEW_ID_TAB_STRIP);
+ set_id(VIEW_ID_TAB_STRIP);
set_background(views::Background::CreateSolidBackground(kBackgroundColor));
AddChildView(newtab_button_);
separator_->set_background(
@@ -225,14 +225,14 @@
views::View* SideTabStrip::GetEventHandlerForPoint(const gfx::Point& point) {
// Check the scroll buttons first as they visually appear on top of everything
// else.
- if (scroll_down_button_->IsVisible()) {
+ if (scroll_down_button_->visible()) {
gfx::Point local_point(point);
View::ConvertPointToView(this, scroll_down_button_, &local_point);
if (scroll_down_button_->HitTest(local_point))
return scroll_down_button_->GetEventHandlerForPoint(local_point);
}
- if (scroll_up_button_->IsVisible()) {
+ if (scroll_up_button_->visible()) {
gfx::Point local_point(point);
View::ConvertPointToView(this, scroll_up_button_, &local_point);
if (scroll_up_button_->HitTest(local_point))
« no previous file with comments | « chrome/browser/ui/views/tabs/base_tab_strip.cc ('k') | chrome/browser/ui/views/tabs/tab.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698