Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Side by Side Diff: views/controls/label.cc

Issue 7057014: Variety of tweaks to View API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "views/controls/label.h" 5 #include "views/controls/label.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 #include <limits> 8 #include <limits>
9 9
10 #include "base/i18n/rtl.h" 10 #include "base/i18n/rtl.h"
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 int Label::GetBaseline() { 179 int Label::GetBaseline() {
180 return GetInsets().top() + font_.GetBaseline(); 180 return GetInsets().top() + font_.GetBaseline();
181 } 181 }
182 182
183 gfx::Size Label::GetPreferredSize() { 183 gfx::Size Label::GetPreferredSize() {
184 // Return a size of (0, 0) if the label is not visible and if the 184 // Return a size of (0, 0) if the label is not visible and if the
185 // collapse_when_hidden_ flag is set. 185 // collapse_when_hidden_ flag is set.
186 // TODO(munjal): This logic probably belongs to the View class. But for now, 186 // TODO(munjal): This logic probably belongs to the View class. But for now,
187 // put it here since putting it in View class means all inheriting classes 187 // put it here since putting it in View class means all inheriting classes
188 // need ot respect the collapse_when_hidden_ flag. 188 // need ot respect the collapse_when_hidden_ flag.
189 if (!IsVisible() && collapse_when_hidden_) 189 if (!visible() && collapse_when_hidden_)
190 return gfx::Size(); 190 return gfx::Size();
191 191
192 gfx::Size prefsize(GetTextSize()); 192 gfx::Size prefsize(GetTextSize());
193 gfx::Insets insets = GetInsets(); 193 gfx::Insets insets = GetInsets();
194 prefsize.Enlarge(insets.width(), insets.height()); 194 prefsize.Enlarge(insets.width(), insets.height());
195 return prefsize; 195 return prefsize;
196 } 196 }
197 197
198 int Label::GetHeightForWidth(int w) { 198 int Label::GetHeightForWidth(int w) {
199 if (!is_multi_line_) 199 if (!is_multi_line_)
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
454 font_, GetAvailableRect().width(), true)); 454 font_, GetAvailableRect().width(), true));
455 } else { 455 } else {
456 *paint_text = UTF16ToWideHack(text_); 456 *paint_text = UTF16ToWideHack(text_);
457 } 457 }
458 458
459 *text_bounds = GetTextBounds(); 459 *text_bounds = GetTextBounds();
460 *flags = ComputeMultiLineFlags(); 460 *flags = ComputeMultiLineFlags();
461 } 461 }
462 462
463 } // namespace views 463 } // namespace views
OLDNEW
« no previous file with comments | « views/controls/combobox/native_combobox_views_unittest.cc ('k') | views/controls/label_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698