Issue 7057012: Add strings for print preveiw <-> cloud print integration.

Issue 7057012: Add strings for print preveiw <-> cloud print integration. (Closed)

Created:
9 years, 7 months ago by Albert Bodenhamer

Modified:
9 years, 7 months ago

Reviewers:
Scott Byer

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add strings for print preveiw <-> cloud print integration. No visible changes. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86152

Patch Set 2 : Respond to feedback #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -0 lines)			Patch
	M	chrome/app/generated_resources.grd	View	1	2 chunks	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Scott Byer

Also pass these by Tyler. http://codereview.chromium.org/7057012/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/7057012/diff/1/chrome/app/generated_resources.grd#newcode5549 chrome/app/generated_resources.grd:5549: Loading the list of ...

9 years, 7 months ago (2011-05-20 17:08:58 UTC) #2

Albert Bodenhamer

On 2011/05/20 17:08:58, Scott Byer wrote: > Also pass these by Tyler. Done. > > ...

9 years, 7 months ago (2011-05-20 17:38:33 UTC) #3

Albert Bodenhamer

http://codereview.chromium.org/7057012/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/7057012/diff/1/chrome/app/generated_resources.grd#newcode5549 chrome/app/generated_resources.grd:5549: Loading the list of printers On 2011/05/20 17:08:58, Scott ...

9 years, 7 months ago (2011-05-20 17:38:43 UTC) #4

Scott Byer

9 years, 7 months ago (2011-05-20 17:52:34 UTC) #5

LGTM

On 2011/05/20 17:38:43, Albert Bodenhamer wrote:
>
http://codereview.chromium.org/7057012/diff/1/chrome/app/generated_resources.grd
> File chrome/app/generated_resources.grd (right):
> 
>
http://codereview.chromium.org/7057012/diff/1/chrome/app/generated_resources....
> chrome/app/generated_resources.grd:5549: Loading the list of printers
> On 2011/05/20 17:08:58, Scott Byer wrote:
> > Do we want this string to be cloud specific? Presumably, getting the local
> > printers is quick.
> 
> As discussed, changed to "Loading additional printers"

Expand Messages | Collapse Messages