Issue 7057009: Convert list policy to string preference. (DefaultSearchProviderEncodings).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7057009: Convert list policy to string preference. (DefaultSearchProviderEncodings). (Closed)

Created:
9 years, 7 months ago by Joao da Silva

Modified:
9 years, 7 months ago

Reviewers:
Mattias Nissler (ping if slow)

CC:
chromium-reviews, Paweł Hajdan Jr., pastarmovj

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Convert list policy to string preference. (DefaultSearchProviderEncodings). Also adapted the unit_tests. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86278

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review, rebase #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -19 lines)			Patch
M	chrome/browser/policy/config_dir_policy_provider_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/configuration_policy_pref_store.cc	View	1	7 chunks	+52 lines, -6 lines	0 comments	Download
M	chrome/browser/policy/configuration_policy_pref_store_unittest.cc	View		7 chunks	+13 lines, -10 lines	0 comments	Download
M	chrome/browser/policy/configuration_policy_provider_mac_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/configuration_policy_provider_win_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

This policy wasn't working at all because the policy type is list, but the preference ...

9 years, 7 months ago (2011-05-20 16:26:05 UTC) #1

Mattias Nissler (ping if slow)

9 years, 7 months ago (2011-05-20 16:56:16 UTC) #2

LGTM with a nit.

http://codereview.chromium.org/7057009/diff/1/chrome/browser/policy/configura...
File chrome/browser/policy/configuration_policy_pref_store.cc (right):

http://codereview.chromium.org/7057009/diff/1/chrome/browser/policy/configura...
chrome/browser/policy/configuration_policy_pref_store.cc:487: // None of the
types has been fixed for backwards compatibility.
That comment only adds confusion. If you think that's desirable, add a TODO. If
you don't think so, just leave it out.

Expand Messages | Collapse Messages