Suppress a GCC 4.6 warning

Suppress a GCC 4.6 warning

BUG=80071
TEST=none

[Ryan Sleevi, 2011-06-05 12:59:25]

evan: PTAL. 

This warning is triggered quite a bit by ICU. It's still not fixed in ICU ToT,
so I don't think a roll anytime soon will fix. I wasn't sure whether or not to
file an individual bug and/or add comments to the .gypi.

FWIW, the error (more or less)

third_party/icu/public/common/unicode/unistr.h: In member function
‘icu_46::UnicodeString& icu_46::UnicodeString::replace(int32_t, int32_t,
UChar32)’:
third_party/icu/public/common/unicode/unistr.h:3986:9: error: variable ‘isError’
set but not used [-Werror=unused-but-set-variable]
third_party/icu/public/common/unicode/unistr.h: In member function
‘icu_46::UnicodeString& icu_46::UnicodeString::append(UChar32)’:
third_party/icu/public/common/unicode/unistr.h:4264:9: error: variable ‘isError’
set but not used [-Werror=unused-but-set-variable]
cc1plus: all warnings being treated as errors

[Evan Martin, 2011-06-05 19:50:27]

Can you:
1) put the review comments in the commit message?
2) put the warning closer to the bad code (e.g. in third_party/icu),
rather than globally?

On Sun, Jun 5, 2011 at 5:59 AM,  <rsleevi@chromium.org> wrote:
> Reviewers: Evan Martin,
>
> Message:
> evan: PTAL.
>
> This warning is triggered quite a bit by ICU. It's still not fixed in ICU
> ToT,
> so I don't think a roll anytime soon will fix. I wasn't sure whether or not
> to
> file an individual bug and/or add comments to the .gypi.
>
> FWIW, the error (more or less)
>
> third_party/icu/public/common/unicode/unistr.h: In member function
> ‘icu_46::UnicodeString& icu_46::UnicodeString::replace(int32_t, int32_t,
> UChar32)’:
> third_party/icu/public/common/unicode/unistr.h:3986:9: error: variable
> ‘isError’
> set but not used [-Werror=unused-but-set-variable]
> third_party/icu/public/common/unicode/unistr.h: In member function
> ‘icu_46::UnicodeString& icu_46::UnicodeString::append(UChar32)’:
> third_party/icu/public/common/unicode/unistr.h:4264:9: error: variable
> ‘isError’
> set but not used [-Werror=unused-but-set-variable]
> cc1plus: all warnings being treated as errors
>
>
>
> Description:
> Suppress a GCC 4.6 warning
>
> BUG=80071
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/7056063/
>
> SVN Base: ssh://mrpenguin/home/Ryan/chromium.msysgit/src@master
>
> Affected files:
>  M build/common.gypi
>
>
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index
>
6083fab050245ecdb2f68c5ee73f05b0c43ac050..c23c5860741e6878630887cb5db987a13e2d7503
> 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -1100,6 +1100,7 @@
>           # '-Wextra',
>           # Don't warn about unused function params.  We use those
> everywhere.
>           '-Wno-unused-parameter',
> +          '-Wno-unused-but-set-variable',
>           # Don't warn about the "struct foo f = {0};" initialization
> pattern.
>           '-Wno-missing-field-initializers',
>           '-D_FILE_OFFSET_BITS=64',
>
>
>