Issue 7056041: Reapply: "Make instanceof and Object.getPrototypeOf work for proxies,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7056041: Reapply: "Make instanceof and Object.getPrototypeOf work for proxies, (Closed)

Created:
9 years, 6 months ago by Mads Ager (chromium)

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium), rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Reapply: "Make instanceof and Object.getPrototypeOf work for proxies, plus a few other tweaks." The problem with the original patch was that it did not take hidden prototype objects into account in Runtime_GetPrototype. R=kmillikin@chromium.org,rossberg@chromium.org TEST=es5conform Committed: http://code.google.com/p/v8/source/detail?r=8164

Patch Set 1 #

Patch Set 2 : Fix for Runtime_GetPrototype #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+303 lines, -47 lines)			Patch
M	src/messages.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/objects.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/proxy.js	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	src/runtime.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	1	2 chunks	+29 lines, -2 lines	1 comment	Download
M	src/v8natives.js	View		6 chunks	+74 lines, -2 lines	0 comments	Download
M	src/x64/builtins-x64.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/mjsunit/harmony/proxies.js	View		3 chunks	+182 lines, -37 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

9 years, 6 months ago (2011-06-03 09:52:48 UTC) #2

LGTM.

http://codereview.chromium.org/7056041/diff/2001/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/7056041/diff/2001/src/runtime.cc#newcode656
src/runtime.cc:656: while (obj->IsJSObject() &&
Maybe clearer with do...while, if you like that sort of thing.

Expand Messages | Collapse Messages