Issue 7056033: Style cleanup in bookmarks import code

Issue 7056033: Style cleanup in bookmarks import code (Closed)

Created:
9 years, 7 months ago by Ilya Sherman

Modified:
9 years, 7 months ago

Reviewers:
Takashi Toyoshima, Miranda Callahan

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Style cleanup in bookmarks import code Splitting out this smaller CL from a larger one cleaning up our bookmark import logic. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86477

Patch Set 1 #

Total comments: 2

Patch Set 2 : Gram 'er? #

Patch Set 3 : Fix unit tests #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -63 lines)			Patch
M	chrome/browser/importer/external_process_importer_bridge.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/importer/external_process_importer_bridge.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/importer/external_process_importer_client.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/importer/firefox2_importer.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/importer/firefox3_importer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/importer/ie_importer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/importer/importer_bridge.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/importer/importer_unittest.cc	View	1 2	3 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/importer/in_process_importer_bridge.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/importer/in_process_importer_bridge.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/importer/profile_import_process_client.h	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/importer/profile_writer.h	View	1 2	2 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/importer/profile_writer.cc	View	1	4 chunks	+18 lines, -22 lines	0 comments	Download
M	chrome/browser/importer/safari_importer.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/importer/toolbar_importer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

LGTM with nit. http://codereview.chromium.org/7056033/diff/1/chrome/browser/importer/profile_writer.cc File chrome/browser/importer/profile_writer.cc (right): http://codereview.chromium.org/7056033/diff/1/chrome/browser/importer/profile_writer.cc#newcode132 chrome/browser/importer/profile_writer.cc:132: // In order to avoid the ...

9 years, 7 months ago (2011-05-21 11:34:21 UTC) #2

Takashi Toyoshima

I could not find any additional problem. If the point Miranda addressed was fixed, it ...

9 years, 7 months ago (2011-05-23 13:11:23 UTC) #3

Ilya Sherman

9 years, 7 months ago (2011-05-24 06:01:13 UTC) #4

Also fixed some tests that were failing on not-Mac :)

http://codereview.chromium.org/7056033/diff/1/chrome/browser/importer/profile...
File chrome/browser/importer/profile_writer.cc (right):

http://codereview.chromium.org/7056033/diff/1/chrome/browser/importer/profile...
chrome/browser/importer/profile_writer.cc:132: // In order to avoid the
imported-to folders from appearing in the 'recently
On 2011/05/21 11:34:21, Miranda Callahan wrote:
> nit: s/avoid/keep

Done.

Expand Messages | Collapse Messages