Issue 7056030: Prevent Unnecessary Processing by HQP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7056030: Prevent Unnecessary Processing by HQP (Closed)

Created:
9 years, 7 months ago by mrossetti

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Prevent Unnecessary Processing by HQP The Search provider calls back into the AutocompleteController and then on to the other providers multiple times during the processing of an autocomplete but it is not necessary for the HQP to handle these calls. BUG=83186 TEST=Times recorded for about:histograms/Omnibox are reduced dramatically. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86287

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	chrome/browser/autocomplete/history_quick_provider.cc	View	1	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

9 years, 7 months ago (2011-05-21 02:40:09 UTC) #2

LGTM

http://codereview.chromium.org/7056030/diff/1/chrome/browser/autocomplete/his...
File chrome/browser/autocomplete/history_quick_provider.cc (right):

http://codereview.chromium.org/7056030/diff/1/chrome/browser/autocomplete/his...
chrome/browser/autocomplete/history_quick_provider.cc:51:
(input.matches_requested() == AutocompleteInput::BEST_MATCH &&
Nit: You might want a comment somewhere like "// Without inline autocompletion,
none of the HQP matches can score highly enough to be the best match."

Expand Messages | Collapse Messages