Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 7056018: Fix ChromeFrame tests which broke after my change to fix empty XHR POST requests to not cache. Re... (Closed)

Created:
9 years, 7 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Fix ChromeFrame tests which broke after my change to fix empty XHR POST requests to not cache. Reason an incorrect bind verb check. BUG=none TEST=chrome frame tests should pass. TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86129

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome_frame/urlmon_url_request.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
9 years, 7 months ago (2011-05-20 19:40:18 UTC) #1
amit
9 years, 7 months ago (2011-05-20 22:36:46 UTC) #2
wow! lgtm :)

On Fri, May 20, 2011 at 12:40 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Fix ChromeFrame tests which broke after my change to fix empty XHR POST
> requests
> to not cache. Reason
> an incorrect bind verb check.
>
> BUG=none
> TEST=chrome frame tests should pass.
> TBR=amit
>
> Please review this at http://codereview.chromium.org/7056018/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/urlmon_url_request.cc
>
>
> Index: chrome_frame/urlmon_url_request.cc
> ===================================================================
> --- chrome_frame/urlmon_url_request.cc  (revision 86115)
> +++ chrome_frame/urlmon_url_request.cc  (working copy)
> @@ -469,7 +469,7 @@
>     lstrcpyW(bind_info->szCustomVerb, verb.c_str());
>   }
>
> -  if (bind_info->dwBindVerb = BINDVERB_POST ||
> +  if (bind_info->dwBindVerb == BINDVERB_POST ||
>       bind_info->dwBindVerb == BINDVERB_PUT) {
>     // Bypass caching proxies on upload requests and avoid writing
> responses to
>     // the browser's cache.
>
>
>

Powered by Google App Engine
This is Rietveld 408576698