Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 7056013: Two tweaks for accelerated painting: (Closed)

Created:
9 years, 7 months ago by sky
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Two tweaks for accelerated painting: . Make sure if there is no texture and we're told to paint, we paint to the whole texture (see comment for details on why we need to do this). . When the transform changes only schedule paint on the widget. By doing this we won't trigger updating the texture, only having the compositor redraw everything. This currently doesn't matter, but will once James lands his changes to SchedulePaint to keep a dirty bit. BUG=none TEST=none R=ben@chromium.org,wjmaclean@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86139

Patch Set 1 #

Patch Set 2 : Tweaks #

Patch Set 3 : Tweaks #

Patch Set 4 : Tweaks #

Total comments: 2

Patch Set 5 : #ifdef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M views/view.cc View 1 2 3 4 2 chunks +29 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
9 years, 7 months ago (2011-05-20 18:06:50 UTC) #1
Ben Goodger (Google)
LGTM http://codereview.chromium.org/7056013/diff/2002/views/view.cc File views/view.cc (right): http://codereview.chromium.org/7056013/diff/2002/views/view.cc#newcode416 views/view.cc:416: if (!texture_.get()) { don't you need this to ...
9 years, 7 months ago (2011-05-20 18:10:02 UTC) #2
sky
GAH! I added the first ifdef. The second one isn't needed because PaintToTexture is already ...
9 years, 7 months ago (2011-05-20 18:17:52 UTC) #3
wjmaclean
9 years, 7 months ago (2011-05-20 18:21:48 UTC) #4
LGTM, too.

Powered by Google App Engine
This is Rietveld 408576698