Replace all usage of FileAutoDeleter with ScopedTempDir.

Replace all usage of FileAutoDeleter with ScopedTempDir.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86617

[lain Merrick, 2011-05-20 13:16:36]

Removing usages of FileAutoDeleter as suggested in the review of
http://codereview.chromium.org/7044010/.

[Paweł Hajdan Jr., 2011-05-20 13:48:58]

Could you also remove FileAutoDeleter completely? I think there is just one
remaining usage in src/chrome/browser/importer/safari_importer_unittest.mm, and
the trybots can make sure it works on a Mac.

http://codereview.chromium.org/7056011/diff/1/chrome/browser/safe_browsing/sa...
File chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc (right):

http://codereview.chromium.org/7056011/diff/1/chrome/browser/safe_browsing/sa...
chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc:27:
ASSERT_FALSE(file_util::PathExists(filename_));
nit: Not needed, please remove.

http://codereview.chromium.org/7056011/diff/1/chrome/browser/sessions/session...
File chrome/browser/sessions/session_service_unittest.cc (right):

http://codereview.chromium.org/7056011/diff/1/chrome/browser/sessions/session...
chrome/browser/sessions/session_service_unittest.cc:41:
file_util::CreateDirectory(path_);
nit: Check return value.

[lain Merrick, 2011-05-20 14:22:56]

On 2011/05/20 13:48:58, Paweł Hajdan Jr. wrote:
> Could you also remove FileAutoDeleter completely? I think there is just one
> remaining usage in src/chrome/browser/importer/safari_importer_unittest.mm,
and
> the trybots can make sure it works on a Mac.

Yup, just did a "find *.mm" and that's the only file that shows up. I'll add it
to this CL.

To remove the class completely, I need to edit chrome_tests.gypi, and that
clashes with my other CL, so I figured I would do that afterwards.

[lain Merrick, 2011-05-20 14:23:32]

http://codereview.chromium.org/7056011/diff/1/chrome/browser/safe_browsing/sa...
File chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc (right):

http://codereview.chromium.org/7056011/diff/1/chrome/browser/safe_browsing/sa...
chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc:27:
ASSERT_FALSE(file_util::PathExists(filename_));
On 2011/05/20 13:48:58, Paweł Hajdan Jr. wrote:
> nit: Not needed, please remove.

Done.

http://codereview.chromium.org/7056011/diff/1/chrome/browser/sessions/session...
File chrome/browser/sessions/session_service_unittest.cc (right):

http://codereview.chromium.org/7056011/diff/1/chrome/browser/sessions/session...
chrome/browser/sessions/session_service_unittest.cc:41:
file_util::CreateDirectory(path_);
On 2011/05/20 13:48:58, Paweł Hajdan Jr. wrote:
> nit: Check return value.

Done.

[Paweł Hajdan Jr., 2011-05-23 18:59:42]

This is great - I think I'd prefer to delete the FileAutoDeleter in the same CL,
but if that makes things easier for you, LGTM.

By the way, git is great for easy management of multiple overlapping changes.

[lain Merrick, 2011-05-24 15:16:43]

Adding Ben for chrome/browser/OWNERS review.

Ben, do you have time to take a quick look at this?

[lain Merrick, 2011-05-25 14:26:02]

Presubmit didn't think I needed OWNERS approval, and the trybots are green, so I
went ahead and submitted this.