views: Split DownloadShelfContextMenuWin out to its own header file.

chrome/browser/ui/views/download/download_shelf_context_menu_view.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/download/download_shelf_context_menu_view.h"
+
+#include "base/i18n/rtl.h"
+#include "base/logging.h"
+#include "chrome/browser/download/download_item.h"
+#include "chrome/browser/download/download_item_model.h"
+#include "ui/gfx/point.h"
+#include "views/controls/menu/menu_2.h"
+
+DownloadShelfContextMenuView::DownloadShelfContextMenuView(
+    BaseDownloadItemModel* model)
+    : DownloadShelfContextMenu(model) {
+    DCHECK(model);
+}
+
+DownloadShelfContextMenuView::~DownloadShelfContextMenuView() {}
+
+void DownloadShelfContextMenuView::Run(const gfx::Point& point) {
+  if (download_item()->IsComplete())

[dmazzoni, 2011/05/22 04:39:49]

Just a thought, but I wonder why DownloadShelfContextMenu shouldn't just have a
method GetMenuModel() that grabs the correct model depending on download_item()
- this could be used both here and in download_item_gtk.cc. A quick code search
shows that GetFinishedMenuModel and GetInProgressMenuModel aren't used anywhere
else.

It's pretty trivial either way, but that would put one more line of logic in the
abstract class and one less in the platform-specific implementations.

+    menu_.reset(new views::Menu2(GetFinishedMenuModel()));
+  else
+    menu_.reset(new views::Menu2(GetInProgressMenuModel()));
+
+  // The menu's alignment is determined based on the UI layout.
+  views::Menu2::Alignment alignment;
+  if (base::i18n::IsRTL())
+    alignment = views::Menu2::ALIGN_TOPRIGHT;
+  else
+    alignment = views::Menu2::ALIGN_TOPLEFT;
+  menu_->RunMenuAt(point, alignment);
+}
+
+void DownloadShelfContextMenuView::Stop() {
+  set_download_item(NULL);
+}