Make git-cl and update_depot_tools msys-compatible.

Make git-cl and update_depot_tools msys-compatible.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86501

[cmp, 2011-05-21 03:57:05]

+maruel

I can run git cl without error via my windows depot_tools git.  More testing to
do to make sure Cygwin git is unaffected.  I'm basing this work on the
assumption the Cygwin git user never ran gclient from a command prompt, and if
they did we do not support that case.

[cmp, 2011-05-21 03:57:29]

+maruel really

[cmp, 2011-05-21 03:59:52]

Note the vanilla msysgit workflow doc uses a Linux system to run git-cl.  This
would be a big workflow improvement for the normal Windows dev following that
doc.

[nsylvain, 2011-05-22 21:09:54]

LGTM

http://codereview.chromium.org/7055025/diff/1/git-cl
File git-cl (right):

http://codereview.chromium.org/7055025/diff/1/git-cl#newcode14
git-cl:14: exec "$base_dir/python_bin/python" "$base_dir"/git_cl.py "$@"
Can you do python.exe here?

http://codereview.chromium.org/7055025/diff/1/update_depot_tools
File update_depot_tools (right):

http://codereview.chromium.org/7055025/diff/1/update_depot_tools#newcode22
update_depot_tools:22: SVN="$base_dir/svn_bin/svn"
svn.exe?

http://codereview.chromium.org/7055025/diff/1/update_depot_tools#newcode27
update_depot_tools:27: GIT="$base_dir/git_bin/bin/git"
git.exe

[M-A Ruel, 2011-05-22 21:30:09]

On 2011/05/21 03:57:05, cmp wrote:
> +maruel
> 
> I can run git cl without error via my windows depot_tools git.  More testing
to
> do to make sure Cygwin git is unaffected.  I'm basing this work on the
> assumption the Cygwin git user never ran gclient from a command prompt, and if
> they did we do not support that case.

That's hard to assume though because it was previously the reverse, the user
_had_ to run gclient from cmd to have it work on cygwin.
I'd prefer to look for uname or something instead.

[cmp, 2011-05-23 22:48:58]

On 2011/05/22 21:30:09, Marc-Antoine Ruel wrote:
> That's hard to assume though because it was previously the reverse, the user
> _had_ to run gclient from cmd to have it work on cygwin.
> I'd prefer to look for uname or something instead.

I updated the scripts to test against uname and verified 'git cl upload' works
on the same system with the same depot_tools in PATH across both Cygwin and
Command Prompt.  In my tests, it worked in the same Git repository, too.  PTAL.

[cmp, 2011-05-23 22:49:05]

http://codereview.chromium.org/7055025/diff/1/git-cl
File git-cl (right):

http://codereview.chromium.org/7055025/diff/1/git-cl#newcode14
git-cl:14: exec "$base_dir/python_bin/python" "$base_dir"/git_cl.py "$@"
On 2011/05/22 21:09:54, nsylvain wrote:
> Can you do python.exe here?

Done.

http://codereview.chromium.org/7055025/diff/1/update_depot_tools
File update_depot_tools (right):

http://codereview.chromium.org/7055025/diff/1/update_depot_tools#newcode22
update_depot_tools:22: SVN="$base_dir/svn_bin/svn"
On 2011/05/22 21:09:54, nsylvain wrote:
> svn.exe?

Done.

http://codereview.chromium.org/7055025/diff/1/update_depot_tools#newcode27
update_depot_tools:27: GIT="$base_dir/git_bin/bin/git"
On 2011/05/22 21:09:54, nsylvain wrote:
> git.exe

Done.

[nsylvain, 2011-05-23 23:22:50]

LGTM

[cmp, 2011-05-23 23:52:14]

+evan, since this is a git-cl related change.

[M-A Ruel, 2011-05-24 17:36:31]

lgtm but I don't know the reason why it's needed at all.

[Evan Martin, 2011-05-24 21:23:46]

I agree with M-A

[Evan Martin, 2011-05-24 21:45:52]

On 2011/05/24 21:23:46, Evan Martin wrote:
> I agree with M-A

(BTW, it would help in the future to make the change description describe the
change -- like, what it's changing and why it's needed.  But in any case four
days for a simple change like this is ridic, you should land it and then we can
chat about it endlessly if we want after that point...)

[nsylvain, 2011-05-25 01:39:03]

On Tue, May 24, 2011 at 10:36 AM, <maruel@chromium.org> wrote:

> lgtm but I don't know the reason why it's needed at all.

Can you explain more why you think it's not needed? I mean, without it,
git-cl just fails on Windows.

>
>
> http://codereview.chromium.org/7055025/
>