Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 7055023: [Sync] Implement search frontend in chrome://sync-internals. (Closed)

Created:
9 years, 7 months ago by akalin
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), arv (Not doing code reviews), tim (not reviewing), idana, lipalani
Visibility:
Public.

Description

[Sync] Implement search frontend in chrome://sync-internals. Add new 'Search' tab. Refactor some javascript code slightly. BUG=76812 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86384

Patch Set 1 #

Patch Set 2 : diff against right branch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -30 lines) Patch
M chrome/browser/resources/sync_internals/chrome_sync.js View 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/browser/resources/sync_internals/search.html View 1 chunk +26 lines, -0 lines 0 comments Download
M chrome/browser/resources/sync_internals/sync_index.html View 4 chunks +23 lines, -0 lines 0 comments Download
M chrome/browser/resources/sync_internals/sync_node_browser.js View 3 chunks +3 lines, -30 lines 0 comments Download
A chrome/browser/resources/sync_internals/sync_search.css View 1 chunk +54 lines, -0 lines 0 comments Download
A chrome/browser/resources/sync_internals/sync_search.js View 1 chunk +92 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
akalin
+tim for review Suggest patching this in and playing around with the tab to get ...
9 years, 7 months ago (2011-05-20 23:49:33 UTC) #1
akalin
On 2011/05/20 23:49:33, akalin wrote: > +tim for review > > Suggest patching this in ...
9 years, 7 months ago (2011-05-20 23:52:31 UTC) #2
akalin
On 2011/05/20 23:52:31, akalin wrote: > On 2011/05/20 23:49:33, akalin wrote: > > +tim for ...
9 years, 7 months ago (2011-05-23 19:00:36 UTC) #3
akalin
+lipalani fyi
9 years, 7 months ago (2011-05-23 20:49:56 UTC) #4
tim (not reviewing)
LGTM
9 years, 7 months ago (2011-05-23 23:04:59 UTC) #5
commit-bot: I haz the power
9 years, 7 months ago (2011-05-24 01:42:10 UTC) #6
Change committed as 86384

Powered by Google App Engine
This is Rietveld 408576698