Issue 7055021: Renames BookmarkModelObserver::BookmarkNodeFaviconLoaded to

Issue 7055021: Renames BookmarkModelObserver::BookmarkNodeFaviconLoaded to (Closed)

Created:
9 years, 7 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
mafv, Erik does not do reviews, Elliot Glaysher, Paweł Hajdan Jr., Ben Goodger (Google), tim (not reviewing)

CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, Erik does not do reviews, kkania, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Renames BookmarkModelObserver::BookmarkNodeFaviconLoaded to BookmarkNodeFaviconChanged and makes it so we send it instead of BookmarkNodeChanged if the favicon changes. BUG=51501 TEST=see bug R=tim@chromium.org TBR=phadjan.jr@chromium.org, erikkay@chromium.org, maf@chromium.org, erg@chromium.org, ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86290

Patch Set 2 : Fix bookmark_load_observer #

Patch Set 4 : Copyrights and spelling #

Patch Set 5 : Merge to trunk #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+202 lines, -222 lines)			Patch
M	chrome/browser/automation/automation_provider_observers.h	View	1 2 3 4	1 chunk	+12 lines, -10 lines	0 comments	Download
M	chrome/browser/bookmarks/base_bookmark_model_observer.h	View	1 2 3	3 chunks	+12 lines, -11 lines	0 comments	Download
M	chrome/browser/bookmarks/base_bookmark_model_observer.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model_observer.h	View	1 2 3	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model_unittest.cc	View		5 chunks	+20 lines, -18 lines	0 comments	Download
M	chrome/browser/extensions/extension_bookmarks_module.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_bookmarks_module.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/bookmark_change_processor.h	View		1 chunk	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/sync/glue/bookmark_change_processor.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.h	View	1 2 3	3 chunks	+13 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm	View		3 chunks	+12 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.h	View		1 chunk	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h	View		1 chunk	+13 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.h	View		1 chunk	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk.h	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/global_bookmark_menu.h	View	1 2	2 chunks	+10 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/gtk/global_bookmark_menu.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_editor_view.h	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h	View	1 2 3 4	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/bookmark_load_observer.h	View	1	1 chunk	+16 lines, -15 lines	0 comments	Download
M	chrome/test/live_sync/bookmark_model_verifier.cc	View		1 chunk	+11 lines, -9 lines	0 comments	Download
M	chrome/test/testing_profile.cc	View		2 chunks	+1 line, -33 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

Tim, could you review this? At least the change to bookmarkmodelobserver and sync and I'll ...

9 years, 7 months ago (2011-05-23 14:55:04 UTC) #1

tim (not reviewing)

BookmarkModel/Observer + sync changes LGTM http://codereview.chromium.org/7055021/diff/3001/chrome/browser/bookmarks/base_bookmark_model_observer.h File chrome/browser/bookmarks/base_bookmark_model_observer.h (right): http://codereview.chromium.org/7055021/diff/3001/chrome/browser/bookmarks/base_bookmark_model_observer.h#newcode22 chrome/browser/bookmarks/base_bookmark_model_observer.h:22: // BookmarModelObserver: nit - ...

9 years, 7 months ago (2011-05-23 15:28:42 UTC) #2

sky

9 years, 7 months ago (2011-05-23 15:51:56 UTC) #3

Tim reviewed the main change (to BookmarkModel/BookmarkObserver). As the rest is
largely just renaming I'm TBRing everyone else.

  -Scott

Expand Messages | Collapse Messages