Print Preview: Delaying page range validation

chrome/browser/resources/print_preview.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var localStrings = new LocalStrings();
 
 // The total page count of the previewed document regardless of which pages the
 // user has selected.
 var totalPageCount = -1;
 
@@ skipping 46 matching lines @@
   $('print-button').disabled = true;
   $('print-button').addEventListener('click', printFile);
   $('all-pages').addEventListener('click', onPageSelectionMayHaveChanged);
   $('copies').addEventListener('input', copiesFieldChanged);
   $('print-pages').addEventListener('click', handleIndividualPagesCheckbox);
   $('individual-pages').addEventListener('blur', function() {
       clearTimeout(timerId);
       onPageSelectionMayHaveChanged();
   });
   $('individual-pages').addEventListener('focus', addTimerToPageRangeField);
-  $('individual-pages').addEventListener('input', pageRangesFieldChanged);
+  $('individual-pages').addEventListener('input', resetPageRangeFieldTimer);
   $('two-sided').addEventListener('click', handleTwoSidedClick)
   $('landscape').addEventListener('click', onLayoutModeToggle);
   $('portrait').addEventListener('click', onLayoutModeToggle);
   $('color').addEventListener('click', function() { setColor(true); });
   $('bw').addEventListener('click', function() { setColor(false); });
   $('printer-list').addEventListener(
       'change', updateControlsWithSelectedPrinterCapabilities);
   $('increment').addEventListener('click',
                                   function() { onCopiesButtonsClicked(1); });
   $('decrement').addEventListener('click',
@@ skipping 16 matching lines @@
 function showSystemDialog() {
   chrome.send('showSystemDialog');
 }
 
 /**
  * Disables the controls which need the initiator tab to generate preview
  * data. This function is called when the initiator tab is closed.
  * @param {string} initiatorTabURL The URL of the initiator tab.
  */
 function onInitiatorTabClosed(initiatorTabURL) {
-  if (isPreviewStillLoading)
-    displayErrorMessage(localStrings.getStringF('initiatorTabClosed',
-                                                initiatorTabURL));
-
-  var controlIDs = ['landscape', 'portrait', 'all-pages', 'print-pages',
-                    'individual-pages', 'printer-list'];
-  var controlCount = controlIDs.length;
-  for (var i = 0; i < controlCount; i++)
-    $(controlIDs[i]).disabled = true;
+  displayErrorMessage(localStrings.getStringF('initiatorTabClosed',
+                                              initiatorTabURL));
 }
 
 /**
  * Gets the selected printer capabilities and updates the controls accordingly.
  */
 function updateControlsWithSelectedPrinterCapabilities() {
   var printerList = $('printer-list');
   var selectedIndex = printerList.selectedIndex;
   if (selectedIndex < 0)
     return;
@@ skipping 407 matching lines @@
  * field.
  */
 function copiesFieldChanged() {
   updateCopiesButtonsState();
   updatePrintButtonState();
   $('collate-option').hidden = getCopies() <= 1;
   updatePrintSummary();
 }
 
 /**
- * Executes whenever an input event occurs on the 'individual-pages'
- * field. It takes care of
+ * Executes whenever a blur event occurs on the 'individual-pages'
+ * field or when the timer expires. It takes care of
  * 1) showing/hiding warnings/suggestions
  * 2) updating print button/summary
  */
 function pageRangesFieldChanged() {
   var currentlySelectedPages = getSelectedPagesSet();
   var individualPagesField = $('individual-pages');
   var individualPagesHint = $('individual-pages-hint');
   var validityLevel = getSelectedPagesValidityLevel();
 
   if (validityLevel == 1)
@@ skipping 102 matching lines @@
  */
 function handleTwoSidedClick() {
   updatePrintSummary();
 }
 
 /**
  * Gives focus to the individual pages textfield when 'print-pages' textbox is
  * clicked.
  */
 function handleIndividualPagesCheckbox() {
-  onPageSelectionMayHaveChanged();
   $('individual-pages').focus();
 }
 
 /**
  * When the user switches printing orientation mode the page field selection is
  * reset to "all pages selected". After the change the number of pages will be
  * different and currently selected page numbers might no longer be valid.
  * Even if they are still valid the content of these pages will be different.
  */
 function onLayoutModeToggle() {
@@ skipping 178 matching lines @@
   addTimerToPageRangeField();
 }
 
 /**
  * When the user stops typing in the page range textfield or clicks on the
  * 'all-pages' checkbox, a new print preview is requested, only if
  * 1) The input is compeletely valid (it can be parsed in its entirety).
  * 2) The newly selected pages differ from the previously selected.
  */
 function onPageSelectionMayHaveChanged() {
+  if ($('print-pages').checked)
+    pageRangesFieldChanged();
   var validityLevel = getSelectedPagesValidityLevel();
   var currentlySelectedPages = getSelectedPagesSet();
 
   // Toggling between "all pages"/"some pages" radio buttons while having an
   // invalid entry in the page selection textfield still requires updating the
   // print summary and print button.
   if (validityLevel < 1 ||
       areArraysEqual(previouslySelectedPages, currentlySelectedPages)) {
     updatePrintButtonState();
     updatePrintSummary();
@@ skipping 25 matching lines @@
     copiesField.value = 1;
   else {
     var newValue = getCopies() + sign * 1;
     if (newValue < copiesField.min || newValue > copiesField.max)
       return;
     copiesField.value = newValue;
   }
   copiesFieldChanged();
 }