Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Issue 7055010: Rename internal gfx::Image members to be less confusing with Cocoa types. (Closed)

Created:
9 years, 7 months ago by Robert Sesek
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, Paweł Hajdan Jr., TVL
Visibility:
Public.

Description

Rename internal gfx::Image members to be less confusing with Cocoa types. BUG=82453 TEST=ui_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86136

Patch Set 1 #

Patch Set 2 : Fix mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -73 lines) Patch
M ui/base/resource/resource_bundle_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gfx/image.cc View 12 chunks +59 lines, -59 lines 0 comments Download
M ui/gfx/image_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M ui/gfx/image_unittest_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Robert Sesek
9 years, 7 months ago (2011-05-20 18:29:59 UTC) #1
Mark Mentovai
9 years, 7 months ago (2011-05-20 18:43:25 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698