Issue 7055007: GTTF: Remove wait_for_terminate_timeout_ms in favor of action_max_timeout_ms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7055007: GTTF: Remove wait_for_terminate_timeout_ms in favor of action_max_timeout_ms (Closed)

Created:
9 years, 7 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Timur Iskhodzhanov, sky

CC:
chromium-reviews, Alexander Potapenko, brettw-cc_chromium.org, kkania, pam+watch_chromium.org, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

GTTF: Remove wait_for_terminate_timeout_ms in favor of action_max_timeout_ms Reducing number of different timeouts makes it easier to choose one. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86127

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -20 lines)			Patch
M	base/test/test_timeouts.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	base/test/test_timeouts.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/service/service_process_control_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/automation/proxy_launcher.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/heapcheck/chrome_tests.py	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/valgrind/chrome_tests.py	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Please review: Scott: entire CL Timur: just the Valgrind part

9 years, 7 months ago (2011-05-20 11:51:59 UTC) #1

LGTM

Expand Messages | Collapse Messages