File upload API in chromedriver

chrome/test/webdriver/commands/webelement_commands.h

Index: chrome/test/webdriver/commands/webelement_commands.h
diff --git a/chrome/test/webdriver/commands/webelement_commands.h b/chrome/test/webdriver/commands/webelement_commands.h
index 5bf8b936ba94ff7c774fbcd2b787178ba1ef00ac..70c98fb00195e3f32e22775716f977bad9e9ecc8 100644
--- a/chrome/test/webdriver/commands/webelement_commands.h
+++ b/chrome/test/webdriver/commands/webelement_commands.h
@@ -15,6 +15,7 @@ class DictionaryValue;
 
 namespace webdriver {
 
+class Error;
 class Response;
 
 // Handles commands that interact with a web element in the WebDriver REST
@@ -249,6 +250,10 @@ class ElementValueCommand : public WebElementCommand {
   virtual void ExecutePost(Response* const response);
 
  private:
+  void SetFilePathsToFileUploadControl(Response* const response) const;

[kkania, 2011/05/23 18:43:49]

how about return Error* for these instead of passing response

[nodchip, 2011/05/26 01:14:53]

Done.

+  void SendKeys(Response* const response) const;
+  Error* GetElementAttribute(const std::string& key, std::string* value) const;
+
   DISALLOW_COPY_AND_ASSIGN(ElementValueCommand);
 };