File upload API in chromedriver

chrome/test/webdriver/commands/webelement_commands.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_WEBDRIVER_COMMANDS_WEBELEMENT_COMMANDS_H_
 #define CHROME_TEST_WEBDRIVER_COMMANDS_WEBELEMENT_COMMANDS_H_
 
 #include <string>
 #include <vector>
 
 #include "chrome/test/webdriver/commands/webdriver_command.h"
 #include "chrome/test/webdriver/web_element_id.h"
 
 class DictionaryValue;
 
 namespace webdriver {
 
+class Error;
 class Response;
 
 // Handles commands that interact with a web element in the WebDriver REST
 // service.
 class WebElementCommand : public WebDriverCommand {
  public:
   WebElementCommand(const std::vector<std::string>& path_segments,
                     const DictionaryValue* const parameters);
   virtual ~WebElementCommand();
 
@@ skipping 214 matching lines @@
   ElementValueCommand(const std::vector<std::string>& path_segments,
                       DictionaryValue* parameters);
   virtual ~ElementValueCommand();
 
   virtual bool DoesGet();
   virtual bool DoesPost();
   virtual void ExecuteGet(Response* const response);
   virtual void ExecutePost(Response* const response);
 
  private:
+  void SetFilePathsToFileUploadControl(Response* const response) const;

[kkania, 2011/05/23 18:43:49]

how about return Error* for these instead of passing response

[nodchip, 2011/05/26 01:14:53]

Done.

+  void SendKeys(Response* const response) const;
+  Error* GetElementAttribute(const std::string& key, std::string* value) const;
+
   DISALLOW_COPY_AND_ASSIGN(ElementValueCommand);
 };
 
 // Gets the visible text of the specified web element.
 // http://code.google.com/p/selenium/wiki/JsonWireProtocol#/session/:sessionId/element/:id/text
 class ElementTextCommand : public WebElementCommand {
  public:
   ElementTextCommand(const std::vector<std::string>& path_segments,
                      DictionaryValue* parameters);
   virtual ~ElementTextCommand();
 
   virtual bool DoesGet();
   virtual void ExecuteGet(Response* const response);
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ElementTextCommand);
 };
 
 }  // namespace webdriver
 
 #endif  // CHROME_TEST_WEBDRIVER_COMMANDS_WEBELEMENT_COMMANDS_H_