Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 7055003: Last gyp patch for cross-platform Unix support (Closed)

Created:
9 years, 7 months ago by ruben
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, cbentzel+watch_chromium.org, sjl, simonmorris+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, dmaclach+watch_chromium.org, jam, apatrick_chromium, garykac+watch_chromium.org, wez+watch_chromium.org, acolwell GONE FROM CHROMIUM, annacc, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), sergeyu+watch_chromium.org, lambroslambrou+watch_chromium.org, scherkus (not reviewing)
Visibility:
Public.

Description

Final gyp patch to make use of the new cross-platform POSIX defines toolkit_uses_gtk, os_posix, and use_x11. For lists of source files that use a mix of POSIX and Gtk APIs, toolkit_uses_gtk was given precedence. Solaris was made to use ALSA also, as libasound has been ported to FreeBSD and Solaris as a wrapper around the native OSS. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86352

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -81 lines) Patch
M courgette/courgette.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M crypto/crypto.gyp View 4 chunks +4 lines, -4 lines 0 comments Download
M gpu/demos/demos.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gpu/gpu.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc.gyp View 2 chunks +3 lines, -3 lines 0 comments Download
M jingle/jingle.gyp View 1 chunk +1 line, -1 line 0 comments Download
M media/media.gyp View 9 chunks +9 lines, -9 lines 0 comments Download
M net/net.gyp View 6 chunks +6 lines, -6 lines 0 comments Download
M net/third_party/nss/ssl.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/ppapi.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing.gyp View 3 chunks +8 lines, -10 lines 1 comment Download
M remoting/remoting.gyp View 6 chunks +6 lines, -6 lines 0 comments Download
M sandbox/sandbox.gyp View 1 chunk +1 line, -1 line 0 comments Download
M skia/skia.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M testing/gtest.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/bzip2/bzip2.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/expat/expat.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libevent/libevent.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/libjingle.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/libjpeg/libjpeg.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libpng/libpng.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libxml/libxml.gyp View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/libxslt/libxslt.gyp View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/mesa/mesa.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/npapi/npapi.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/qcms/qcms.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/snappy/snappy.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/sqlite/sqlite.gyp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/zlib/zlib.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ruben
Last gyp file patch to make them more cross-platform across the Unix platforms. Tony is ...
9 years, 7 months ago (2011-05-20 04:59:19 UTC) #1
tony
LGTM, I will run this through the try bots. http://codereview.chromium.org/7055003/diff/1/printing/printing.gyp File printing/printing.gyp (right): http://codereview.chromium.org/7055003/diff/1/printing/printing.gyp#newcode92 printing/printing.gyp:92: ...
9 years, 7 months ago (2011-05-20 16:09:37 UTC) #2
commit-bot: I haz the power
Try job failure for 7055003-1 on linux: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux&number=28029
9 years, 7 months ago (2011-05-23 18:52:24 UTC) #3
ruben
On 2011/05/23 18:52:24, commit-bot wrote: > Try job failure for 7055003-1 on linux: > http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux&number=28029 ...
9 years, 7 months ago (2011-05-23 21:39:08 UTC) #4
tony
9 years, 7 months ago (2011-05-23 22:07:28 UTC) #5
On 2011/05/23 21:39:08, ruben wrote:
> On 2011/05/23 18:52:24, commit-bot wrote:
> > Try job failure for 7055003-1 on linux:
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux&numb...
> Looks like everything goes through fine, except for the check_deps script. 
I'm
> not sure what those gles2_conform_support files are that the check_deps script
> is pulling, as they don't seem to be listed anywhere else, so I don't see any
> connection with this gyp patch.

Yeah, I think it's unrelated.  Committed manually in r86352.

Powered by Google App Engine
This is Rietveld 408576698