Issue 7055002: Fix PPAPI ui_tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7055002: Fix PPAPI ui_tests. (Closed)

Created:
9 years, 7 months ago by piman

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, Paweł Hajdan Jr., garianov1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix PPAPI ui_tests. r66321 silently broke it because we were not running the tests, just listing the tests and yet returning success. This fixes it as well as some regressions in the tests themselves. BUG=none TEST=ui_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86166

Patch Set 1 #

Patch Set 2 : Disable transport test #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -11 lines)			Patch
M	chrome/test/ui/ppapi_uitest.cc	View	1	4 chunks	+9 lines, -6 lines	0 comments	Download
M	ppapi/tests/test_case.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/tests/test_graphics_2d.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/tests/test_image_data.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	ppapi/tests/testing_instance.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

piman

I'm changing this to disable Transport test which crashes on linux - http://code.google.com/p/chromium/issues/detail?id=83395

9 years, 7 months ago (2011-05-20 18:33:51 UTC) #3

darin (slow to review)

9 years, 7 months ago (2011-05-20 20:53:25 UTC) #4

OK, LGTM

On Fri, May 20, 2011 at 11:33 AM, <piman@chromium.org> wrote:

> I'm changing this to disable Transport test which crashes on linux -
> http://code.google.com/p/chromium/issues/detail?id=83395
>
>
> http://codereview.chromium.org/7055002/
>

Expand Messages | Collapse Messages