Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 7054074: Limit the number of arguments in a function call to 32766. (Closed)

Created:
9 years, 6 months ago by William Hesse
Modified:
8 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Limit the number of arguments in a function call to 32766. Limit the number of arguments in a function call to 32766. This is identical to the limit on the number of parameters to a function. BUG=v8:1413 TEST= Committed: http://code.google.com/p/v8/source/detail?r=8194

Patch Set 1 #

Patch Set 2 : Add regression test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -10 lines) Patch
M src/messages.js View 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-1122.js View 1 3 chunks +23 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
William Hesse
9 years, 6 months ago (2011-06-06 16:16:34 UTC) #1
Erik Corry
The parameter limit was introduced for security reasons that don't seem to apply here
9 years, 6 months ago (2011-06-06 16:24:25 UTC) #2
Kevin Millikin (Chromium)
LGTM.
9 years, 6 months ago (2011-06-07 04:43:01 UTC) #3
pandit.mandar1
8 years, 8 months ago (2012-04-10 13:45:59 UTC) #4
On 2011/06/07 04:43:01, Kevin Millikin wrote:
> LGTM.

I am also getting the same error in my application... My citydetals.js file will
populates cities of world with their Id and names .. I am having 40000 cities
and getting issue in google chrome....please suggest!
I am passing 40000 arguments in new array functions as citinames...

Powered by Google App Engine
This is Rietveld 408576698