Issue 7054063: Fix a lock re-entry bug in GpuDataManager::UpdateGpuInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7054063: Fix a lock re-entry bug in GpuDataManager::UpdateGpuInfo. (Closed)

Created:
9 years, 6 months ago by Zhenyao Mo

Modified:
9 years, 6 months ago

Reviewers:
jbates

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a lock re-entry bug in GpuDataManager::UpdateGpuInfo. The issue is that the registered callbacks could request GPUInfo, so they could re-enter the lock. Therefore, we should release the lock before we run through callbacks. BUG=84805 TEST=the issue in 84805 is gone. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87898

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	content/browser/gpu/gpu_data_manager.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jbates

9 years, 6 months ago (2011-06-03 23:00:36 UTC) #2

On 2011/06/03 22:53:48, Zhenyao Mo wrote:
> Please review.

LGTM

Expand Messages | Collapse Messages