Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 7054062: Fix for sync setup UI when user is already logged in. (Closed)

Created:
9 years, 6 months ago by binji
Modified:
9 years, 6 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Fix for sync setup UI when user is already logged in. Every time the dialog is loaded, the read-only email address would be appended to the span. BUG=84665 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88404

Patch Set 1 #

Patch Set 2 : Merge with trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/browser/resources/options/sync_setup_overlay.html View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/sync_setup_overlay.js View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
binji
A pretty simple fix. The "reset-shown" class stuff is to simplify resetting the dialog. See ...
9 years, 6 months ago (2011-06-03 21:53:22 UTC) #1
binji
9 years, 6 months ago (2011-06-03 23:04:30 UTC) #2
binji
ping
9 years, 6 months ago (2011-06-07 01:24:57 UTC) #3
Evan Stade
lgtm
9 years, 6 months ago (2011-06-07 03:12:31 UTC) #4
commit-bot: I haz the power
Can't apply patch for file chrome/browser/resources/options/sync_setup_overlay.html. While running patch -p1 --forward --force; patching file chrome/browser/resources/options/sync_setup_overlay.html ...
9 years, 6 months ago (2011-06-07 17:49:44 UTC) #5
commit-bot: I haz the power
Try job failure for 7054062-6001 on linux_clang for step compile: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=2217
9 years, 6 months ago (2011-06-07 19:11:17 UTC) #6
commit-bot: I haz the power
Try job failure for 7054062-6001 on mac for step unit_tests: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number=31037
9 years, 6 months ago (2011-06-07 23:18:24 UTC) #7
commit-bot: I haz the power
9 years, 6 months ago (2011-06-08 21:13:27 UTC) #8
Change committed as 88404

Powered by Google App Engine
This is Rietveld 408576698