Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 7054057: Add support for empty files, __init__.py is a common example. (Closed)

Created:
9 years, 6 months ago by M-A Ruel
Modified:
9 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Add support for empty files, __init__.py is a common example. Use p.is_new signal and set it manually with rietveld patches. Add regression test for +x. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -22 lines) Patch
M apply_issue.py View 2 chunks +6 lines, -8 lines 0 comments Download
M checkout.py View 4 chunks +18 lines, -10 lines 0 comments Download
M rietveld.py View 1 chunk +9 lines, -4 lines 0 comments Download
M tests/patch_test.py View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
9 years, 6 months ago (2011-06-03 20:39:15 UTC) #1
Dirk Pranke
9 years, 6 months ago (2011-06-03 20:54:41 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698