Adding padding at the bottom of internet details page, so we make room for button strip (and avoi...

Adding padding at the bottom of internet details page, so we make room for button strip (and avoid its overlapping with page contents)

BUG=chromium-os:12995
TEST=Made sure buttons on the internet details dialog don't overlapp with contents in any of its tabs.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88401

[Dmitry Polukhin, 2011-06-04 18:15:22]

http://codereview.chromium.org/7054056/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/chromeos/internet_options_page.css
(right):

http://codereview.chromium.org/7054056/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/chromeos/internet_options_page.css:99:
min-height: 380px;
Could you please make sure that first tab for GSM network looks fine with
min-height 380? In case of GSM we add 3 more editboxes for APN settings. Perhaps
we should increase min-height if GSM case doesn't fit in 380px.

[tbarzic, 2011-06-08 04:09:56]

http://codereview.chromium.org/7054056/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/chromeos/internet_options_page.css
(right):

http://codereview.chromium.org/7054056/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/chromeos/internet_options_page.css:99:
min-height: 380px;
On 2011/06/04 18:15:22, Dmitry Polukhin wrote:
> Could you please make sure that first tab for GSM network looks fine with
> min-height 380? In case of GSM we add 3 more editboxes for APN settings.
Perhaps
> we should increase min-height if GSM case doesn't fit in 380px.

I don't think it fits...the window gets resized so the tab fits in it, but,
yeah, it is probably better that the window dimensions stay constant as we
change tabs...
I also changed min-width so width/height ratio stays similar..

[Dmitry Polukhin, 2011-06-08 11:17:53]

LGTM