Issue 7054034: Push the general AST id field down from ASTNode to Expression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7054034: Push the general AST id field down from ASTNode to Expression. (Closed)

Created:
9 years, 6 months ago by Sven Panne

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium), danno

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Push the general AST id field down from ASTNode to Expression. Almost all uses were below Expression already, only a single use in IfStatement had to be handled explicitly (probably an oversight from earlier changes?). This is a small step towards a less ad-hoc handling of IDs in the front end.

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -16 lines)			Patch
M	src/ast.h	View	8 chunks	+9 lines, -12 lines	0 comments	Download
M	src/full-codegen.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/full-codegen.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages