Add in support for connecting with just the OAuth2 token. Default to OAuth2.

Add in support for connecting with just the OAuth2 token. Default to OAuth2.

BUG=none
TEST=local appengine instance connects via OAuth2 and ClientLogin

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86374

[awong, 2011-05-21 01:07:30]

Another OAuth2 fix.

[Jamie, 2011-05-23 19:24:12]

http://codereview.chromium.org/7054029/diff/1/remoting/client/appengine/api.py
File remoting/client/appengine/api.py (right):

http://codereview.chromium.org/7054029/diff/1/remoting/client/appengine/api.p...
remoting/client/appengine/api.py:27: json.dumps({'xmpp_token':
auth.GetClientLoginToken().token}))
Does the name of the token also need to change from xmpp_token like the class
and method name did?

http://codereview.chromium.org/7054029/diff/1/remoting/client/appengine/hostl...
File remoting/client/appengine/hostlist.html (right):

http://codereview.chromium.org/7054029/diff/1/remoting/client/appengine/hostl...
remoting/client/appengine/hostlist.html:52: Use OAuth2
We should probably use a <label> here and below, otherwise the radio button is a
bit hard to click on.

http://codereview.chromium.org/7054029/diff/1/remoting/client/appengine/stati...
File remoting/client/appengine/static_files/chromoting_session.js (right):

http://codereview.chromium.org/7054029/diff/1/remoting/client/appengine/stati...
remoting/client/appengine/static_files/chromoting_session.js:56:
chromoting.plugin.connectSandboxed(clientjid, chromoting.hostjid);
Add a TODO here to revisit once it's been renamed and supports oauth2 tokens?

[awong, 2011-05-23 20:43:22]

http://codereview.chromium.org/7054029/diff/1/remoting/client/appengine/api.py
File remoting/client/appengine/api.py (right):

http://codereview.chromium.org/7054029/diff/1/remoting/client/appengine/api.p...
remoting/client/appengine/api.py:27: json.dumps({'xmpp_token':
auth.GetClientLoginToken().token}))
On 2011/05/23 19:24:12, Jamie wrote:
> Does the name of the token also need to change from xmpp_token like the class
> and method name did?

Apparently no one even calls this. I've just removed it entirely.

http://codereview.chromium.org/7054029/diff/1/remoting/client/appengine/hostl...
File remoting/client/appengine/hostlist.html (right):

http://codereview.chromium.org/7054029/diff/1/remoting/client/appengine/hostl...
remoting/client/appengine/hostlist.html:52: Use OAuth2
On 2011/05/23 19:24:12, Jamie wrote:
> We should probably use a <label> here and below, otherwise the radio button is
a
> bit hard to click on.

Done.

http://codereview.chromium.org/7054029/diff/1/remoting/client/appengine/stati...
File remoting/client/appengine/static_files/chromoting_session.js (right):

http://codereview.chromium.org/7054029/diff/1/remoting/client/appengine/stati...
remoting/client/appengine/static_files/chromoting_session.js:56:
chromoting.plugin.connectSandboxed(clientjid, chromoting.hostjid);
On 2011/05/23 19:24:12, Jamie wrote:
> Add a TODO here to revisit once it's been renamed and supports oauth2 tokens?

Don't think it's necessary.  All that code will just break anyways. :)

[Jamie, 2011-05-23 20:52:04]

LGTM.