Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 7054025: Try another way to alias a variable in optimized builds. (Closed)

Created:
9 years, 7 months ago by apatrick_chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Try another way to alias a variable in optimized builds. The previous way did not fool LTCG optimization. I tested that this works by doing and LTCG build without this change and verified that the compiler strips out the assignment to program_counter in MessageLoop::RunTask. Then I repeated with this change and verified that the compiler did not strip it out. TEST=compiles plus the above BUG=81449 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86172

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M base/debug/alias.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
apatrick_chromium
Please review, thanks.
9 years, 7 months ago (2011-05-20 23:03:17 UTC) #1
darin (slow to review)
9 years, 7 months ago (2011-05-20 23:28:05 UTC) #2
OK, LGTM

Powered by Google App Engine
This is Rietveld 408576698