Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 7054023: Get rid of url_request_tracking.*. The only other place that used it other than ResourceDispatch... (Closed)

Created:
9 years, 7 months ago by jam
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Erik does not do reviews, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Get rid of url_request_tracking.*. The only other place that used it other than ResourceDispatcherHost was the plugin installer. It doesn't really matter which process the request for downloading a plugin (which is very infrequent) shows up for, and arguably, it's better to show up under the browser process. BUG=76697 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86324

Patch Set 1 : '' #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -111 lines) Patch
M chrome/browser/chrome_plugin_message_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_plugin_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/user_script_listener_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/net/url_request_tracking.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/net/url_request_tracking.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M chrome/browser/plugin_download_helper.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/plugin_download_helper.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ssl/ssl_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/default_plugin/plugin_impl_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/plugin/plugin_test.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/DEPS View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host.cc View 4 chunks +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_request_info.h View 3 chunks +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_request_info.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/resource_queue_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/plugin_messages.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
Brett: sending you this since you wrote url_request_tracking
9 years, 7 months ago (2011-05-20 21:43:20 UTC) #1
jam
Avi: Brett is gone, do you mind taking a look? Thanks
9 years, 7 months ago (2011-05-23 16:52:42 UTC) #2
Avi (use Gerrit)
Code LGTM; you still might want Brett to OK it.
9 years, 7 months ago (2011-05-23 18:28:29 UTC) #3
jam
9 years, 7 months ago (2011-05-23 19:35:42 UTC) #4
Brett: if you have any comments on this, let me know and I'll do them in a
followup.

Powered by Google App Engine
This is Rietveld 408576698