Refactors code for showing bookmark menus so that it can be used by

Refactors code for showing bookmark menus so that it can be used by
both the bookmark bar and wrench menu and wires bookmarks into the
wrench menu.

BUG=81263
TEST=thoroughly test bookmarks in the wrench menu to make sure there
     aren't any crashes/weird behavior.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86175

[sky, 2011-05-20 21:23:06]

Another approach I could have taken here is to have WrenchMenu and
BookmarkMenuControllerViews extend BookmarkMenuDelegate. I may have shied away
from subclassing too aggressively here. Do you feel strongly either way here?

  -Scott

[Ben Goodger (Google), 2011-05-20 21:31:32]

Feels a little weird to me to have the WrenchMenu know so much about the
bookmark menu. I assume the D&D stuff is to allow you to drag into the wrench
icon and have it pop open?

[sky, 2011-05-20 21:41:51]

MenuItemView only supports one MenuDelegate for all the descendants.
Since WrenchMenu is already the MenuDelegate that means it has to
forward interesting MenuDelegate methods to BookmarkMenuDelegate. This
is why you see all the overrides, although they are nothing more than
call through methods.

  -Scott

On Fri, May 20, 2011 at 2:31 PM,  <ben@chromium.org> wrote:
> Feels a little weird to me to have the WrenchMenu know so much about the
> bookmark menu. I assume the D&D stuff is to allow you to drag into the
> wrench
> icon and have it pop open?
>
> http://codereview.chromium.org/7054020/
>

[Ben Goodger (Google), 2011-05-20 21:43:05]

Ah. Well I like this more than more invasive subclassing... LGTM.

On Fri, May 20, 2011 at 2:41 PM, Scott Violet <sky@chromium.org> wrote:

> MenuItemView only supports one MenuDelegate for all the descendants.
> Since WrenchMenu is already the MenuDelegate that means it has to
> forward interesting MenuDelegate methods to BookmarkMenuDelegate. This
> is why you see all the overrides, although they are nothing more than
> call through methods.
>
>  -Scott
>
> On Fri, May 20, 2011 at 2:31 PM,  <ben@chromium.org> wrote:
> > Feels a little weird to me to have the WrenchMenu know so much about the
> > bookmark menu. I assume the D&D stuff is to allow you to drag into the
> > wrench
> > icon and have it pop open?
> >
> > http://codereview.chromium.org/7054020/
> >
>