Issue 7054013: Cleans up bookmark_bar_view. In particular makes sure order of methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7054013: Cleans up bookmark_bar_view. In particular makes sure order of methods (Closed)

Created:
9 years, 7 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Cleans up bookmark_bar_view. In particular makes sure order of methods in .cc matches .h. Adds OVERRIDE where applicable. Groups methods in related sections. And removes a bit of dead code. TBR=ben@chromium.org BUG=none TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86132

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+557 lines, -664 lines)			Patch
	M	chrome/browser/ui/views/bookmarks/bookmark_bar_view.h	View		10 chunks	+130 lines, -211 lines	0 comments	Download
	M	chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc	View		16 chunks	+427 lines, -453 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM